[packman] ffmpeg-4 fails to compile

[İsmail Dönmez]

On Sat, Jul 10, 2021 at 1:32 PM Hans-Peter Jansen <hpj at urpla.net> wrote:
>
> Hi İsmail,
>
> always nice to hear from you!

Same here :-)

> Am Samstag, 10. Juli 2021, 12:37:28 CEST schrieb İsmail Dönmez:
> > Hi,
> >
> > On Sat, Jul 10, 2021 at 12:33 PM Hans-Peter Jansen <hpj at urpla.net> wrote:
> > > Hi Packmans,
> > >
> > > in order to avoid duplicate work and to give you a heads up, I submitted a
> > > fixed version of ffmpeg-4 to multimedia:libs
> > >
> > > https://build.opensuse.org/request/show/905444
> >
> > I don't think your patch is wrong, but I'd suggest backporting
> > init_fail on top the old patch:
> > https://github.com/cisco-open-source/ffmpeg/blob/master/libavcodec/ac3enc.c#
> > L2490
>
> Hmm, are you sure about it? Seems, you're looking into an old source.
>
> I would have referred you to
>
> https://git.ffmpeg.org/gitweb/ffmpeg.git/blob/HEAD:/libavcodec/ac3enc.c
>
> but that's failing for me.
>
> Here's the head/master of GH mirror:
>
> https://github.com/FFmpeg/FFmpeg/blob/master/libavcodec/ac3enc.c

And of course, you are right *facepalm*, I see the patch was accepted
already, and it's a good compromise. Worst case it'd leak some memory
on exit, but it's a non-issue.

Regards,
ismail