[packman] [PMBS] SR 248 Essentials/lame

[Pascal Bleser]

On 2012-07-18 14:48:14 (+0100), Cristian Morales Vega <reddwarf at opensuse.org> wrote:
> On 15 July 2012 14:46, PMBS <pmbs at links2linux.org> wrote:
> > New submit request 248 on lame by RedDwarf
> > https://pmbs.links2linux.org/request/show/248

> > - update to 3.99.5

> Given that two days later a different patch was committed and this SR
> was not even rejected it seems we still have a problem with #PM-9 and
> making people aware of SRs.

Yes, sorry, my bad, I was on a short 12.2 fixing spree after
adding it to the repos (and had to fix lame) and didn't see your
SR :\

> Anyway. About the committed version:
> - The license seems to be LGPL-2.0+, no LGPL-2.1+
> - lame-tgetstr.patch is kept, forcing a autoreconf call that makes the
> build fail in old distributions, even if I don't think it's needed. I
> don't know a lot about curses, but: When libtinfo was splitted it
> wasn't done in the best way, but soon after a linker script was used
> to avoid the need of patching other packages. In my SR I didn't use it
> and the only difference in the result is that in <12.2 I linked
> against libncurses instead of libncursesw... but since in >= 12.2 only
> libtinfo is used I don't think it really matters.

I presume that libncurses on recent openSUSE versions is also
UTF-8 (normally only libncursesw is) and hence, indeed, you're
most probably right.

> SR#248 has other changes that are less important, but those two IMHO
> should be fixed.

Sorry again, and thanks for the changes.
I re-merged the funky patching that's needed on 12.2 to disable
outdated automake/autoconf features though.

cheers
-- 
  -o) Pascal Bleser
  /\\ http://opensuse.org -- we haz green
 _\_v http://fosdem.org   -- we haz conf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: not available
URL: <http://lists.links2linux.de/pipermail/packman/attachments/20120721/73bf6777/attachment.sig>