[packman] libffmpeg-devel

[Manfred Tremmel]

Am Samstag, 5. März 2011 schrieb Cristian Morales Vega:
> libffmpeg-devel has:
> 
> Requires:       libmp3lame-devel
> Requires:       libogg-devel
> Requires:       libvorbis-devel
> Requires:       libtheora-devel >= 1.1
> Requires:       alsa-devel
> Requires:       slang-devel
> Requires:       zlib-devel
> Requires:       libxvidcore-devel
> %if %{with libfaac}
> Requires:       libfaac-devel
> %endif
> Requires:       libx264-devel
> Requires:       libopencore-amr-devel
> Requires:       libjack-devel
> Requires:       libspeex-devel
> Requires:       libgsm-devel
> Requires:       libdc1394
> Requires:       libdc1394-devel
> %if %suse_version >= 1030
> Requires:       libschroedinger-devel
> Requires:       liboil-devel >= 0.3.15
> Requires:       libdirac-devel >= 1.0.0
> %endif
> %if %suse_version <= 1130
> Requires:       libdc1394_control12-devel
> %endif
> %if %{with libopenjpeg}
> Requires:       libopenjpeg-devel
> %endif
> Requires:       libvdpau-devel
> 
> Is it really needed?

This list ist more or less equal to the BuildRequires list of the ffmpeg 
package. It wasn't analysed file by file.

> From a quick look it seems all those Requires aren't needed:
> 
> $ fgrep x264 $(rpm -ql libffmpeg-devel | fgrep .h)
> /usr/include/libavcodec/avcodec.h:#define CODEC_FLAG2_MBTREE
> 0x00040000 ///< Use macroblock tree ratecontrol (x264 only)
> /usr/include/libavcodec/avcodec.h:     * 8 (umh), 9 (iter), 10 (tesa)
> [7, 8, 10 are x264 specific, 9 is snow specific]
> $ fgrep speex $(rpm -ql libffmpeg-devel | fgrep .h)
> $
> 
> The problem is that if it isn't really needed it's adding unneeded
> dependencies which mean unneeded rebuilds in the OBS.
> Right now a package which uses ffmpeg but doesn't use x264 will be
> rebuilt with each x264 change.

Hm, if x264 changes ffmpeg is rebuild, because ffmpeg itselve is build 
against x264. If ffmpeg is rebuild it triggers rebuilds of all packages 
which are build agains ffmpeg, didn't it? What rebuild can be saved if 
the libx264-devel dependency is removed? The trigger is only moved from 
libx264-devel to libffmpeg-devel, isn't it?

> P.S. devel package with unneeded Requires for othe devel packages
> looks like a general problem in Packman, this is not the only one. If
> the build power is a problem...

If I missunderstood the mechanism you are right and we should remove 
unused requirments.

-- 
Machs gut    | http://www.iivs.de/schwinde/buerger/tremmel/

Manfred      | http://packman.links2linux.de/