[packman] [PM] mediatomb 0.12.1.svn2103-14.25 (openSUSE Tumbleweed/x86_64): Fixes for taglib support (resend)
Heiko Schröder
heiko.schroeder at t-online.de
Sat Apr 28 12:40:32 CEST 2018
Hi,
seems my provider had some mail delivery problems recently, so I'm not
sure if the original mail was delivered successfully. Resending it just
to be sure:
I just found and fixed two problems in the taglib handling of mediatomb:
When converting a UTF-8 TagLib::String to a std::String the size()
function cannot be used to derive the size of the C string. Doing so
might loose (multi-byte) characters in the conversion. (Fixed by patch
mediatomb-taglib-utf8.patch)
Mediatomb uses the TagLib::FileRef(char*) constructor of taglib. This
will open the file in read-write mode and thus trigger a CLOSE_WRITE
notify event for the file afterwards. This, obviously, makes mediatomb
re-read the file if inotify-support is enabled. This causes unnecessary
load during initial scanning and may even make mediatomb fail to work
for UPNP clients that read the album art while displaying the object
list (as the object ID is unexpectedly changed). This is fixed by the
patch mediatomb-taglib-readonly.patch which uses TagLib::FileStream in
read-only mode.
I'm sending the patches to you in the hope that you find them useful for
inclusion into the packman build of the packages (mediatomb upstream
development doesn't seem to be active anymore).
CU
Heiko
More information about the Packman
mailing list