[packman] full featured chromium for SLE12 missing

[Olaf Hering]

On Tue, Jan 12, Olaf Hering wrote:

> I think for SLED and for simplicity the packman_bs yes/no knob in the
> spec file should be converted into a bcond to build the individual
> subpackages. The default should be as it is done now, only the main pkg
> gets build. In Essentials prjconf the ffmpeg subpackage will be enabled,
> the main pkg gets disabled. And for SLE_12 both get enabled.

something like this works for me:

Index: chromium.spec
===================================================================
--- chromium.spec	(revision ff5660680375ea7947bc64d89d65ea62)
+++ chromium.spec	(working copy)
@@ -18,6 +18,8 @@
 
 %define chromium_no_dlopen 1
 %define chromium_system_libs 1
+%bcond_without chromium_subpkg_main
+%bcond_without chromium_subpkg_ffmpeg
 %bcond_without libva
 
 Name:           chromium
@@ -105,7 +107,7 @@
 BuildRequires:  libopenssl-devel
 BuildRequires:  libpulse-devel
 
-%if !0%{?packman_bs}
+%if %{with chromium_subpkg_main}
 BuildRequires:  ninja
 %endif
 BuildRequires:  libdrm-devel
@@ -191,7 +193,7 @@
 BuildRequires:  texinfo
 #Requirements to build a fully functional ffmpeg
 # This can only be done on packman OBS
-%if 0%{?packman_bs}
+%if %{with chromium_subpkg_ffmpeg}
 BuildRequires:  libfaac-devel >= 1.28
 BuildRequires:  libmp3lame-devel
 BuildRequires:  libopencore-amr-devel
@@ -267,7 +269,7 @@
 WebDriver is an open source tool for automated testing of webapps across many browsers. It provides capabilities for navigating to web pages, user input, JavaScript execution, and more. ChromeDriver is a standalone server which implements WebDriver's wire protocol for Chromium. It is being developed by members of the Chromium and WebDriver teams.
 
 
-%if 0%{?packman_bs}
+%if %{with chromium_subpkg_ffmpeg}
 %package ffmpeg
 Summary:        The ffmpeg library for Google's opens source browser Chromium
 License:        BSD-3-Clause and LGPL-2.1+
@@ -292,7 +294,7 @@
 %patch5 -p0
 %patch7 -p0
 %patch8 -p0
-%if 0%{?packman_bs}
+%if %{with chromium_subpkg_ffmpeg}
 %patch9 -p0
 %endif
 %if 0%{?suse_version} > 1320
@@ -335,7 +337,7 @@
                      -Denable_webrtc=1 
                      -Denable_widevine=1"
 
-%if 0%{?packman_bs}
+%if %{with chromium_subpkg_ffmpeg}
 myconf+=" -Dffmpeg_branding=Chrome
           -Dclang=0"
 %endif
@@ -413,11 +415,13 @@
 
 build/linux/unbundle/replace_gyp_files.py $myconf
 
-%if 0%{?packman_bs}
+%if %{with chromium_subpkg_ffmpeg}
     ./build/gyp_chromium -f make third_party/ffmpeg/ffmpeg.gyp --no-parallel --depth . $myconf
-    cd third_party/ffmpeg
+    pushd third_party/ffmpeg
     make -r %{?_smp_mflags} -f ffmpeg.Makefile BUILDTYPE=Release V=1
-%else
+    popd
+%endif
+%if %{with chromium_subpkg_main}
     export GYP_GENERATORS='ninja'
     ./build/gyp_chromium build/all.gyp --depth .  $myconf
 
@@ -432,11 +436,12 @@
 
 %install
 mkdir -p %{buildroot}%{_libdir}/chromium/lib
-%if 0%{?packman_bs}
+%if %{with chromium_subpkg_ffmpeg}
 	pushd third_party/ffmpeg/out/Release/lib.target/
 	cp -a libffmpeg.so %{buildroot}%{_libdir}/chromium/lib
 	popd
-%else
+%endif
+%if %{with chromium_subpkg_main}
 	%ifarch x86_64
 	mkdir -p %{buildroot}%{_prefix}/lib/
 	%endif
@@ -562,7 +567,7 @@
 
 # Files!
 
-%if 0%{?packman_bs}
+%if %{with chromium_subpkg_ffmpeg}
 
 %files ffmpeg
 %defattr(-,root,root,-)
@@ -570,7 +575,8 @@
 %dir %{_libdir}/chromium/lib
 %{_libdir}/chromium/lib/libffmpeg.so
 
-%else
+%endif
+%if %{with chromium_subpkg_main}
 
 %files
 %defattr(-,root,root,-)