[packman] Patches for some Munin plugins

Gabriele Pohl gp at dipohl.com
Sun Aug 12 20:16:07 CEST 2012


Hi packagers,

I found and fixed some small issues concerning
the following Munin Plugins:

- users
- memory
- apache_processes

I use your package for SuSE 12.1
-> munin-node-1.4.5-2.32.noarch

# munin-run users
Use of qw(...) as parentheses is deprecated at /etc/munin/plugins/users
line 82.

 # munin-run apache_processes
Use of qw(...) as parentheses is deprecated at
/etc/munin/plugins/apache_processes line 164.

# munin-run memory
Use of qw(...) as parentheses is deprecated at /etc/munin/plugins/memory
line 175.

I herewith the patches, that fix these errors,
as the website https://bugs.links2linux.org/
is

Btw. I saw, that these issues are already fixed
in Munins development versions on github:
https://github.com/munin-monitoring/munin/tree/devel/plugins

>From which sources do you build the packages?

So far for the start and
thanks for your work!

Gabriele

------------------------------

# diff -u users  /usr/lib/munin/plugins/users
--- users	2012-08-09 23:39:03.000000000 +0200
+++ /usr/lib/munin/plugins/users	2012-07-31 01:00:42.548382943 +0200
@@ -79,7 +79,7 @@
 	print "other.label Other users\n";
 	print "other.info Users loged in by indeterminate method\n";
 	print "other.colour FF0000\n";
-	foreach my $field qw(tty pty pts X other) {
+	foreach my $field (qw(tty pty pts X other)) {
 		print_thresholds($field);
 	}
 	exit 0;

# diff -u memory /usr/lib/munin/plugins/memory
--- memory	2012-08-09 23:39:03.000000000 +0200
+++ /usr/lib/munin/plugins/memory	2012-07-31 00:59:11.001278143 +0200
@@ -172,7 +172,7 @@
 	print "inact_clean.draw LINE1\n";
 	print "inact_clean.info Memory not currently used.\n";
     }
-    for my $field qw(apps buffers swap cached free slab swap_cache
page_tables vmalloc_used committed mapped active active_anon
active_cache inactive inact_dirty inact_laundry inact_clean) {
+    for my $field (qw(apps buffers swap cached free slab swap_cache
page_tables vmalloc_used committed mapped active active_anon
active_cache inactive inact_dirty inact_laundry inact_clean)) {
         print_thresholds($field);
     }
     exit 0;

# diff -u apache_processes /usr/lib/munin/plugins/apache_processes
--- apache_processes	2012-08-09 23:39:01.000000000 +0200
+++ /usr/lib/munin/plugins/apache_processes	2012-07-30
00:19:19.860264849 +0200
@@ -161,7 +161,7 @@
 	    print "free$port.colour ccff00\n";
 	}
 	foreach my $port (@PORTS) {
-		foreach my $type qw "busy idle" {
+		foreach my $type (qw(busy idle)) {
 			print_thresholds("$type$port");
 		}
 	}




More information about the Packman mailing list