[packman] mp3blaster for openSUSE 11.2 - fixes for SPEC and Patch for gcc-4.4

[Axel K.]

Hi there,

While trying to rebuild mp3blaster-3.2.3-1.pm.1.1.src.rpm on openSUSE 11.2, I ran into two tiny problems.

a) ./configure complained about missing includes for lirc

b) compilation failed with an error complaining about an illegal conversion from "const char*" to "char*" 

Here are my fixes for that.

SPEC:

Source:         http://switch.dl.sourceforge.net/sourceforge/mp3blaster/%{name}-%{version}.tar.gz
Patch0:         mp3blaster-3.2.3-missing_includes.patch

Patch1:         mp3blaster-3.2.3-gcc44.diff #Patch added

BuildRoot:      %{_tmppath}/%{name}-%{version}-build
BuildRequires:  gcc-c++ libvorbis-devel lirc ncurses-devel libsidplay1-devel

%if 0%{?suse_version} >= 1120 #openSUSE 11.2 has split lirc-devel off the lirc-package
BuildRequires:  lirc-devel 
%endif

.............................................................................................

%prep
%setup -q
%patch0

%if 0%{?suse_version} >= 1120 # apply patch only for openSUSE >= 11.2
%patch1 -p0
%endif

PATCH:

--- src/global.cc.orig	2009-11-13 11:12:28.000000000 +0100
+++ src/global.cc	2009-11-13 11:12:53.000000000 +0100
@@ -379,7 +379,7 @@
 is_sid(const char *filename)
 {
 #ifdef HAVE_SIDPLAYER
-	char *ext = strrchr(filename, '.');
+	const char *ext = strrchr(filename, '.');
 	if (ext) {
 		if (!strcasecmp(ext, ".psid")) return 1;
 		if (!strcasecmp(ext, ".sid")) return 1;


See also Attachment.

Greetz,

RM