[packman] [PM] digiband 1.0.2-0.pm.1 (openSUSE 11.0/x86_64)

[Toni]

Am Montag, 18. August 2008 schrieb Christian Morales Vega:
> 2008/8/8 Toni <toni at links2linux.de>:
> > So feel free to file a bug to upstream.
>
> Was easier than that. The solution is available in their forums ->
> http://www.digiband.net/index.php?section=forums&subsection=3&ftopic=47

you have read the answer ?
07.07.2008: ".. When I get a chance I'll take a look at that. .."

and yes, this is a "programming" error, especially on 64bit, and as usual the 
authors show there standard behaviour.

> I have verified that with this patch (sorry, I'm not sure about how to
> submit a proper patch through mail, and windows vs linux end lines
> probably will make this unapplicable) the game works.
>
> --- Source/playpreview.C
> +++ Source/playpreview.C
> @@ -24,12 +24,12 @@
>         printf("playpreview\n");
>         #endif
>         char test[256];
> -       static bool firstrun=true;
> -       static char thepreview[256];
> -       if (firstrun){
> +//     static bool firstrun=true;
> +       static char thepreview[256] = {0};
> +/*     if (firstrun){
>                 memset(thepreview, 0, 255 * sizeof(char *));
>                 firstrun=false;
> -       }
> +       }*/
>         snprintf(thepreview,355,"NULL");
>         switch(currscreen){
>                 case 1:
>
>
> I don't think the " = {0}" is needed, but the forum post said to add
> it and I'm not really a programmer, so...
The initialisation won't harm and IMHO it is a good practice to have all 
variables initialized :)

Our mailing-list doesn't allow attachments, so next time you can send the 
patch directly to me.

A new package is uploaded. Please test it and give a small feedback if it is 
working as expected now for you.

Big thx for investigating this error and submitting a solution!

-- 
have fun
Toni