[packman] Kodi Leia PVR Addons: Fail to build due to an error in a tarball in a tarball...

[Dave Plater]

On 1/17/19, Manfred Hollstein <manfred.h at gmx.net> wrote:
> Moin,
>
> the current package sources from home:sagiben/kodi.binary-addons contain
> a line:
>
>   Source3:        kodi.binary-addons.tar
>
> which itself contains a file "build/download/vfs.libarchive-master.tar.gz"
> which then fails during compilation (for openSUSE_Leap_42.3) due to two
> undefined types:
>
>
> /home/abuild/rpmbuild/BUILD/xbmc-18.0rc5-Leia/cmake/addons/build/vfs.libarchive/src/ArchiveFile.cpp:184:10:
>   error: 'la_ssize_t' does not name a type; did you mean '__ssize_t'?
>
> /home/abuild/rpmbuild/BUILD/xbmc-18.0rc5-Leia/cmake/addons/build/vfs.libarchive/src/ArchiveFile.cpp:194:10:
>   error: 'la_int64_t' does not name a type; did you mean 'u_int64_t'?
>
> After unpacking the tarball(s) I fail to see these two types being
> defined anywhere - however, compilation on openSUSE_Leap_15.0 succeeds.
> Could it be that this file should
>
> extern "C" {
> #include <unistd.h>
> }
>
> which would then #include <bits/types.h> for the missing types? Don't
> know, though, where the #define for 'la_ssize_t' and 'la_int64_t' should
> then come from, but that is probably the usual configure trickery.
>
> How is such a file in a tarball in a tarball supposed to be patched? Or,
> how is the first tarball generated?
>
> HTH, TIA, cheers.
>
> l8er
> manfred
>
With great difficulty, you have go past the %cmake stage after which
all the sources are unpacked in the right places and then make your
patch using diff. There are two patches applied at that stage atm.
Regards
Dave